RSDK-7843: Do not remove resources when a remote has a transient error. #4268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
dgottlieb
commented
Aug 6, 2024
| @@ -131,7 +131,7 @@ func isClosedPipeError(err error) bool { | |||
| } | |||
|
|
|||
| func (rc *RobotClient) notConnectedToRemoteError() error { | |||
| return errors.Errorf("not connected to remote robot at %s", rc.address) | |||
There was a problem hiding this comment.
This usage adds a stack trace to the error. I found them to be an eyesore and not at all helpful.
dgottlieb
commented
Aug 6, 2024
robot/client/client.go
Outdated
| @@ -346,7 +346,10 @@ func (rc *RobotClient) connectWithLock(ctx context.Context) error { | |||
| if err := rc.conn.Close(); err != nil { | |||
| return err | |||
| } | |||
| conn, err := grpc.Dial(ctx, rc.address, rc.logger, rc.dialOptions...) | |||
|
|
|||
| cancelCtx, stop := context.WithTimeout(ctx, time.Second) | |||
There was a problem hiding this comment.
Oops, need to revert this and see if there's a better option for speeding up the test.
dgottlieb
commented
Aug 6, 2024
robot/client/client.go
Outdated
| @@ -406,6 +409,7 @@ func (rc *RobotClient) checkConnection(ctx context.Context, checkEvery, reconnec | |||
| return | |||
| } | |||
| } | |||
| rc.logger.Info("Waiting to recheck. WaitTime:", waitTime) | |||
dgottlieb
commented
Aug 6, 2024
| @@ -709,9 +713,8 @@ func (rc *RobotClient) PackageManager() packages.Manager { | |||
| return nil | |||
| } | |||
|
|
|||
| // ResourceNames returns a list of all known resource names connected to this machine. | |||
| // | |||
| // resource_names := machine.ResourceNames() | |||
There was a problem hiding this comment.
Didn't know if this served a purpose -- happy to reintroduce if there's some magic documentation thing going on here
dgottlieb
commented
Aug 6, 2024
| for _, resName := range newResources { | ||
| remoteResName := resName | ||
| res, err := rr.ResourceByName(remoteResName) // this returns a remote known OR foreign resource client |
There was a problem hiding this comment.
Nothing changed here. Just code movement. What's important is this is now below oldline 215/newline 208. I hope the comment I added to the new code outlines the significance.
There is no test coverage of the error case here.
viambot
added
safe to test
6 tasks
maximpertsov
added a commit
to maximpertsov/rdk
that referenced
this pull request
Aug 9, 2024
maximpertsov
added a commit
to maximpertsov/rdk
that referenced
this pull request
Aug 9, 2024
maximpertsov
added a commit
to maximpertsov/rdk
that referenced
this pull request
Aug 20, 2024
maximpertsov
added a commit
to maximpertsov/rdk
that referenced
this pull request
Aug 21, 2024
maximpertsov
added a commit
to maximpertsov/rdk
that referenced
this pull request
Sep 16, 2024
maximpertsov
added a commit
to maximpertsov/rdk
that referenced
this pull request
Sep 17, 2024
maximpertsov
added a commit
to maximpertsov/rdk
that referenced
this pull request
Sep 18, 2024
maximpertsov
added a commit
to maximpertsov/rdk
that referenced
this pull request
Sep 23, 2024
maximpertsov
added a commit
to maximpertsov/rdk
that referenced
this pull request
Sep 24, 2024
maximpertsov
added a commit
to maximpertsov/rdk
that referenced
this pull request
Sep 24, 2024
|
this change is incorporated into #4273, so I'm removing myself as a reviewer |
maximpertsov
added a commit
to maximpertsov/rdk
that referenced
this pull request
Oct 3, 2024
maximpertsov
added a commit
to maximpertsov/rdk
that referenced
this pull request
Oct 4, 2024
ported from PR: viamrobotics#4268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.